Fix B3 propagator to not crash work with DefaultSpan#1148
Merged
codeboten merged 1 commit intoopen-telemetry:masterfrom Sep 23, 2020
Merged
Fix B3 propagator to not crash work with DefaultSpan#1148codeboten merged 1 commit intoopen-telemetry:masterfrom
codeboten merged 1 commit intoopen-telemetry:masterfrom
Conversation
owais
force-pushed
the
b3-propagation-fixes
branch
3 times, most recently
from
dbe2092 to
c039cb2
Compare
ocelotl
approved these changes
Sep 23, 2020
lzchen
approved these changes
Sep 23, 2020
codeboten
approved these changes
Sep 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Nice, looks like linting needs some attention otherwise it looks great!
owais
force-pushed
the
b3-propagation-fixes
branch
from
c039cb2 to
8709002
Compare
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
B3 propagator was crashing as it could not find
.contextand.parentattributes when passed a context with a DefaultSpan instance. I ran into it while trying to instrument a demo grpc service with opentelemetry. I think grpc instrumentation might probably have another issue where it extracts context from incoming request and uses that as the parent for an outgoing request missing the spans in between. I plan to look into that as well later.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: