Fix zipkin exporter translation bug#1149
Merged
codeboten merged 2 commits intoopen-telemetry:masterfrom Sep 23, 2020
Merged
Conversation
owais
force-pushed
the
fix-zipkin-exporter-translation
branch
3 times, most recently
from
ae4a9d7 to
a085664
Compare
owais
force-pushed
the
fix-zipkin-exporter-translation
branch
from
a085664 to
1762b74
Compare
ocelotl
approved these changes
Sep 23, 2020
lzchen
approved these changes
Sep 23, 2020
codeboten
approved these changes
Sep 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing this, looks like some CI failures occurred, they don't appear to be related though so I triggered the build again.
Zipkin exporter translation was setting `otel.status_code` attribute as an integer which resulted in Otel collector rejecting the spans. This commit casts the value to a string.
owais
force-pushed
the
fix-zipkin-exporter-translation
branch
from
1762b74 to
541edab
Compare
Contributor
Author
|
@codeboten The lint job was timing out. Resolved on another force push. |
Contributor
|
Thanks @owais! |
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
…1149) Zipkin exporter translation was setting `otel.status_code` attribute as an integer which resulted in Otel collector rejecting the spans. This commit casts the value to a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Zipkin exporter translation was setting
otel.status_codeattribute asan integer which resulted in Otel collector rejecting the spans. This
commit casts the value to a string.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: