Make zipkin tag value length configurable#1151
Merged
codeboten merged 2 commits intoopen-telemetry:masterfrom Sep 24, 2020
Merged
Make zipkin tag value length configurable#1151codeboten merged 2 commits intoopen-telemetry:masterfrom
codeboten merged 2 commits intoopen-telemetry:masterfrom
Conversation
owais
changed the title
owais
force-pushed
the
configurable-zipkin-tag-size
branch
4 times, most recently
from
663ac6e to
c72d409
Compare
owais
changed the title
owais
force-pushed
the
configurable-zipkin-tag-size
branch
from
c72d409 to
58f3134
Compare
codeboten
suggested changes
Sep 24, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Minor change requested, otherwise it looks good.
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
owais
force-pushed
the
configurable-zipkin-tag-size
branch
from
58f3134 to
ffc4660
Compare
lzchen
reviewed
Sep 24, 2020
|
|
||
| ## Unreleased | ||
|
|
||
| - Zipkin exporter now accepts a ``max_tag_value_length`` attribute to customize the maximum allowed size a tag value can have. |
lzchen
approved these changes
Sep 24, 2020
Zipkin exporter truncates tag values to a maximum length of 128 characters. This commit makes this value configurable while keeping 128 as the default value.
owais
force-pushed
the
configurable-zipkin-tag-size
branch
from
ffc4660 to
480a061
Compare
owais
added a commit
to owais/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
Zipkin exporter truncates tag values to a maximum length of 128 characters. This commit makes this value configurable while keeping 128 as the default value.
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: add missing span sampling test * chore: add additional sampling test Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Zipkin exporter truncates tag values to a maximum length of 128
characters. This commit makes this value configurable while keeping
128 as the default value.
The change required to move some functions to the zipkin exporter class. This has a nice side-effect of the zipkin exporter becoming a bit more customizable by sub-classing it. It can especially be very useful for vendor distributions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: