Conversation
This tracer implements the OpenTracing API using OpenTelemetry internally. This includes unit tests too.
|
Hey, Thanks for the PR, but this is not the approach we are looking for - first of all, I don't see why we need to have a dependency to Second, we only want to expose publicly a way to retrieve an OpenTracing out of an OpenTelemetry Tracer, nothing else: import opentracingshim
tracer = opentracingshim.create_tracer(io.opentelemetry.tracer())
with tracer.start_active_span("one") as scope:
scope.span.set_tag("my", "tag")Which means we cannot any actual implementation of See how the WIP looks for Java for reference (mostly missing OT Baggage support): https://github.com/open-telemetry/opentelemetry-java/tree/master/opentracing_shim/src/main/java/io/opentelemetry/opentracingshim (you don't have to port this, as there are enough differences). |
|
Updating here for visibility - I am continuing @alban's work on this following the feedback from @carlosalberto. I shall open a new PR with an initial implementation soon (I can also update this one if preferred). |
|
Superseded by #211. This PR can be closed. |
This tracer implements the OpenTracing API using OpenTelemetry internally.
This includes unit tests too.
TODO: