Data points in exporter shouldnt use bound instruments by ocelotl · Pull Request #1237 · open-telemetry/opentelemetry-python

ocelotl · 2020-10-13T23:44:15Z

Fixes #1236

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Updated translate_metrics test

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been updated
Documentation has been updated

lzchen

There are several changes in the PR that are not listed in the description. Can you add CHANGELOG entries to otlp, system metrics and sdk packages to explain what is changed?

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/aggregate.py

ocelotl · 2020-10-16T19:55:40Z

There are several changes in the PR that are not listed in the description. Can you add CHANGELOG entries to otlp, system metrics and sdk packages to explain what is changed?

Done 👍

codeboten

Couple of questions I'd like answered before approving

instrumentation/opentelemetry-instrumentation-system-metrics/CHANGELOG.md

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/controller.py

opentelemetry-sdk/CHANGELOG.md

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py

lzchen

I would split this pr up into multiple prs if we are changing more behavior than what is outlined in the current issue.

ocelotl · 2020-10-28T15:48:15Z

I would split this pr up into multiple prs if we are changing more behavior than what is outlined in the current issue.

I removed the wrong commits, this PR is as it was before now.

lzchen

LGTM. If you can create an issue for the last_checkpoint_timestamp that'd be great.

Co-authored-by: Mayur Kale <mayurkale@google.com>

ocelotl self-assigned this Oct 13, 2020

ocelotl force-pushed the issue_1236 branch 2 times, most recently from b17530e to 5026b9b Compare October 16, 2020 04:46

ocelotl marked this pull request as ready for review October 16, 2020 05:01

ocelotl requested review from a team, codeboten and hectorhdzg and removed request for a team October 16, 2020 05:01

ocelotl force-pushed the issue_1236 branch from 5026b9b to 32b7fda Compare October 16, 2020 05:03

ocelotl changed the title ~~WIP: data points in exporter shouldnt use bound instruments~~ Data points in exporter shouldnt use bound instruments Oct 16, 2020

lzchen requested changes Oct 16, 2020

View reviewed changes

lzchen reviewed Oct 16, 2020

View reviewed changes

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py Show resolved Hide resolved

lzchen reviewed Oct 16, 2020

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/aggregate.py Show resolved Hide resolved

ocelotl requested a review from lzchen October 16, 2020 19:55

codeboten suggested changes Oct 16, 2020

View reviewed changes

instrumentation/opentelemetry-instrumentation-system-metrics/CHANGELOG.md Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/controller.py Outdated Show resolved Hide resolved

codeboten reviewed Oct 16, 2020

View reviewed changes

opentelemetry-sdk/CHANGELOG.md Outdated Show resolved Hide resolved

ocelotl force-pushed the issue_1236 branch from 83226c5 to b8a2a81 Compare October 16, 2020 21:44

ocelotl requested a review from codeboten October 16, 2020 21:44

codeboten reviewed Oct 19, 2020

View reviewed changes

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py Show resolved Hide resolved

ocelotl requested a review from codeboten October 19, 2020 22:09

codeboten approved these changes Oct 20, 2020

View reviewed changes

ocelotl force-pushed the issue_1236 branch from aa166f2 to 9a1dca2 Compare October 21, 2020 20:26

NathanielRN mentioned this pull request Oct 22, 2020

Move exporter otlp open-telemetry/opentelemetry-python-contrib#80

Closed

1 task

lzchen reviewed Oct 28, 2020

View reviewed changes

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed Oct 28, 2020

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed Oct 28, 2020

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed Oct 28, 2020

View reviewed changes

...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py Outdated Show resolved Hide resolved

lzchen requested changes Oct 28, 2020

View reviewed changes

ocelotl requested a review from lzchen October 28, 2020 15:31

ocelotl force-pushed the issue_1236 branch 2 times, most recently from 9a1dca2 to d9c4da6 Compare October 28, 2020 15:47

ocelotl force-pushed the issue_1236 branch from 641a35f to 75b81bf Compare October 28, 2020 22:06

lzchen assigned lzchen and unassigned ocelotl Oct 29, 2020

Alex Boten and others added 5 commits October 29, 2020 13:23

Data points in exporter shouldnt use bound instruments

7d573e1

Update changelogs

f7235b6

Remove wrong Changelog message

0cd8e58

Move debug controller

2acbc30

Update changelog

ce40a20

ocelotl force-pushed the issue_1236 branch from 75b81bf to ce40a20 Compare October 29, 2020 19:24

Merge branch 'master' into issue_1236

f1a9145

lzchen approved these changes Oct 31, 2020

View reviewed changes

lzchen merged commit 7d9b0e5 into open-telemetry:master Oct 31, 2020

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020

fix(package.json): publish source maps (open-telemetry#1237)

153169a

Co-authored-by: Mayur Kale <mayurkale@google.com>

ocelotl mentioned this pull request Nov 13, 2020

time_unix_nano and start_time_unix_nano may be wrongly set #1340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data points in exporter shouldnt use bound instruments#1237

Data points in exporter shouldnt use bound instruments#1237
lzchen merged 6 commits intoopen-telemetry:masterfrom
ocelotl:issue_1236

ocelotl commented Oct 13, 2020 •

edited

Loading

Uh oh!

lzchen left a comment

Uh oh!

Uh oh!

Uh oh!

ocelotl commented Oct 16, 2020

Uh oh!

codeboten left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lzchen left a comment

Uh oh!

ocelotl commented Oct 28, 2020

Uh oh!

lzchen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ocelotl commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

How Has This Been Tested?

Uh oh!

lzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ocelotl commented Oct 16, 2020

Uh oh!

codeboten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lzchen left a comment

Choose a reason for hiding this comment

Uh oh!

ocelotl commented Oct 28, 2020

Uh oh!

lzchen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ocelotl commented Oct 13, 2020 •

edited

Loading