Http metrics example file name "http.py" leads to error while importing requests library #1268#1269
Closed
pavankrish123 wants to merge 3 commits intoopen-telemetry:masterfrom
cisco:master
Closed
Http metrics example file name "http.py" leads to error while importing requests library #1268#1269pavankrish123 wants to merge 3 commits intoopen-telemetry:masterfrom cisco:master
pavankrish123 wants to merge 3 commits intoopen-telemetry:masterfrom
cisco:master
Conversation
naming a file http.py leads to shadowing of http module in urllib
|
Contributor
Author
|
Signed the CLA's from Cisco |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…telemetry#1269) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This is a minor fix for a small issue from PR #1116. The example file for demonstrating http metrics is named as http.py. This leads to a shadow import with another file in requests causing the import scream.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Renamed the file to something appropriate
http_metrics.pyand that resolved the issue. Verified the example is working as expected[ X] Test A
Checklist: