Skip to content

Update protobuf versions#1356

Merged
codeboten merged 1 commit intoopen-telemetry:masterfrom
ocelotl:issue_1355
Nov 5, 2020
Merged

Update protobuf versions#1356
codeboten merged 1 commit intoopen-telemetry:masterfrom
ocelotl:issue_1355

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Nov 4, 2020

Fixes #1355

Description

Updates the version of protobuf to the latest one.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

All regular tests are passing.

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl self-assigned this Nov 4, 2020
@ocelotl ocelotl marked this pull request as ready for review November 4, 2020 21:48
@ocelotl ocelotl requested review from a team, codeboten and lzchen and removed request for a team November 4, 2020 21:48
zip_safe = False
include_package_data = True
install_requires =
protobuf~=3.12.2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might the ~= be better throughout?

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Nov 5, 2020

@NathanielRN
Just a heads up, this PR would be affected by the migration.

@codeboten codeboten added the instrumentation Related to the instrumentation of third party libraries or frameworks label Nov 5, 2020
@codeboten codeboten merged commit e3cba02 into open-telemetry:master Nov 5, 2020
@NathanielRN
Copy link
Copy Markdown
Contributor

@codeboten This is a pretty small change, but I was hoping we'd still be frozen on merging Contrib touching PRs until we get the rest of the PRs I have pending merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instrumentation Related to the instrumentation of third party libraries or frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting versions of protobuf

5 participants