Add __getnewargs__ to SpanContext class#1380
Merged
codeboten merged 11 commits intoopen-telemetry:masterfrom Nov 16, 2020
rickychu:bug_pickle_support_spancontext
Merged
Add __getnewargs__ to SpanContext class#1380codeboten merged 11 commits intoopen-telemetry:masterfrom rickychu:bug_pickle_support_spancontext
codeboten merged 11 commits intoopen-telemetry:masterfrom
rickychu:bug_pickle_support_spancontext
Conversation
Contributor
Author
I have a multiprocessing script where the pools need to continue with the span context so it has to be pickled. Error: It works in 0.13b0 with span.get_context() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SpanContext does not support pickle due to missing getnewargs function. Add function to SpanContext.
Fixes # (issue)
#1375
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: