Return none for Getter if key does not exist#1449
Merged
lzchen merged 9 commits intoopen-telemetry:masterfrom Dec 8, 2020
Merged
Return none for Getter if key does not exist#1449lzchen merged 9 commits intoopen-telemetry:masterfrom
lzchen merged 9 commits intoopen-telemetry:masterfrom
Conversation
lzchen
requested review from
a team,
codeboten and
hectorhdzg
and removed request for
a team
codeboten
reviewed
Dec 7, 2020
| ) -> typing.Optional[typing.List[str]]: | ||
| val = carrier.get(key, None) | ||
| if val is None: | ||
| return None |
codeboten
reviewed
Dec 7, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Just a question around testing, otherwise this looks pretty good.
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1274