Add support for OTLP v0.6.0#1472
Merged
codeboten merged 16 commits intoopen-telemetry:masterfrom Jan 5, 2021
Merged
Conversation
srikanthccv
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
srikanthccv
commented
Dec 13, 2020
|
|
||
| OK = 1 | ||
| """The operation has been validated by an Application developer or Operator to have completed successfully.""" | ||
|
|
Member
Author
There was a problem hiding this comment.
Enum order as followed in OTLP v0.6.0 and Spec.
Contributor
There was a problem hiding this comment.
I would have thought this would've broke some tests in contrib that compared the enum numerical value, but I guess not!
…thon into otlp-0.6.0
lzchen
approved these changes
Jan 4, 2021
codeboten
approved these changes
Jan 5, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This looks great thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1376
Fixes #1294