Set max number of commits in performance graph#1498
Merged
codeboten merged 1 commit intoopen-telemetry:masterfrom Dec 22, 2020
Merged
Set max number of commits in performance graph#1498codeboten merged 1 commit intoopen-telemetry:masterfrom
codeboten merged 1 commit intoopen-telemetry:masterfrom
Conversation
NathanielRN
requested review from
a team,
hectorhdzg and
toumorokoshi
and removed request for
a team
codeboten
reviewed
Dec 21, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Looks like the issue/pr in the description is incorrect
Contributor
Author
|
@codeboten Thanks! That was the Contrib PR... I’ve updated it! |
aabmass
approved these changes
Dec 21, 2020
ocelotl
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1443, this PR adds a limit to the number of commits saved and displayed in the performance graph.
By default there is no limit so I thought this would be a good preemptative measure to avoid a noisy (and maybe unreadable?) graph.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Does This PR Require a Contrib Repo Change?
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated