Allow to start_as_current_span with end_on_exit=False#1519
Merged
lzchen merged 5 commits intoopen-telemetry:masterfrom Jan 21, 2021
Merged
Allow to start_as_current_span with end_on_exit=False#1519lzchen merged 5 commits intoopen-telemetry:masterfrom
start_as_current_span with end_on_exit=False#1519lzchen merged 5 commits intoopen-telemetry:masterfrom
Conversation
lzchen
approved these changes
Jan 15, 2021
codeboten
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
start_as_current_spanis just a helper that combinesstart_spananduse_spanmethods. But it doesn't allow to changeend_on_exitattribute. When it's required user have to call two underlying methods explicitly. Wrapper should expose all attributes to cover all cases.Example use case:
Type of change
How Has This Been Tested?
Unit tests updated respectively
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: