Remove rate property setter from TraceIdRatioBasedSampler#1536
Merged
lzchen merged 5 commits intoopen-telemetry:masterfrom Jan 19, 2021
Merged
Remove rate property setter from TraceIdRatioBasedSampler#1536lzchen merged 5 commits intoopen-telemetry:masterfrom
lzchen merged 5 commits intoopen-telemetry:masterfrom
Conversation
srikanthccv
requested review from
a team,
ocelotl and
toumorokoshi
and removed request for
a team
toumorokoshi
approved these changes
Jan 19, 2021
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
LGTM. Might be worth raising an issue to the spec to clarify that you can't change the sampler after instantiation.
Member
Author
Yes, that would make it clear for others also. I will create an issue. |
lzchen
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From Sampler spec
This implies rate should not be changed after instantiation, hence removing the rate setter from
TraceIdRatioBasedSampler. Adding cache doesn't really change anything as there are no computationally expensive operations.