Merged
Conversation
codeboten
requested review from
a team,
hectorhdzg and
toumorokoshi
and removed request for
a team
added 3 commits
February 1, 2021 14:50
10 tasks
lzchen
reviewed
Feb 2, 2021
| self._name = name | ||
| self._context = context | ||
| self._parent = parent | ||
| self.sampler = sampler |
Contributor
There was a problem hiding this comment.
Can we lock down sampler, traceconfig and span_processor?
Contributor
|
As discussed with @codeboten , not certain yet if the current PR adds much value if we don't prevent the "writeable" property on the span when passed into the spanprocessor. |
added 8 commits
February 2, 2021 10:48
Contributor
Author
Span now returns a |
lzchen
reviewed
Feb 9, 2021
lzchen
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ReadableSpanto provide read-only access to attributes of a SpanFixes #1001
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: