Use environment variables for tracer and meter providers#1571
Merged
lzchen merged 1 commit intoopen-telemetry:mainfrom Feb 4, 2021
Merged
Use environment variables for tracer and meter providers#1571lzchen merged 1 commit intoopen-telemetry:mainfrom
lzchen merged 1 commit intoopen-telemetry:mainfrom
Conversation
srikanthccv
approved these changes
Feb 3, 2021
codeboten
approved these changes
Feb 3, 2021
aabmass
approved these changes
Feb 3, 2021
| @@ -59,8 +67,13 @@ def _load_provider(provider: str) -> Provider: | |||
|
|
|||
|
|
|||
| def _load_meter_provider(provider: str) -> "MeterProvider": | |||
Member
There was a problem hiding this comment.
Should we remove the provider arg altogether? I don't see when it would be anything different, its hardcoded in both spots:
Contributor
|
Are these defined in the spec? |
Contributor
I believe these fall under https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#language-specific-environment-variables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1569
Description
Meter and Tracer provider environment variables were not consistent with the rest after
Configurationwas removed, this fixes that problem.Fixes #1569
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: