Skip to content

Rename DefaultSpan to NonRecordingSpan#1661

Merged
lzchen merged 3 commits intoopen-telemetry:mainfrom
lzchen:rec
Mar 2, 2021
Merged

Rename DefaultSpan to NonRecordingSpan#1661
lzchen merged 3 commits intoopen-telemetry:mainfrom
lzchen:rec

Conversation

@lzchen
Copy link
Copy Markdown
Contributor

@lzchen lzchen commented Mar 2, 2021

Fixes #1635

@lzchen lzchen requested review from a team, codeboten and toumorokoshi and removed request for a team March 2, 2021 16:25
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lzchen lzchen merged commit 74e2441 into open-telemetry:main Mar 2, 2021
@lzchen lzchen deleted the rec branch March 2, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider hiding DefaultSpan

3 participants