Skip to content

move textmap propagators to opentelemetry.propagators#1662

Merged
codeboten merged 5 commits intoopen-telemetry:mainfrom
codeboten:move-getter-setter
Mar 3, 2021
Merged

move textmap propagators to opentelemetry.propagators#1662
codeboten merged 5 commits intoopen-telemetry:mainfrom
codeboten:move-getter-setter

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

@codeboten codeboten commented Mar 2, 2021

Description

Moving Getter, Setter and TextMapPropagator out of opentelemetry.trace.propagation and into opentelemetry.propagators

Fixes #1638

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@codeboten codeboten requested review from a team, hectorhdzg and lzchen and removed request for a team March 2, 2021 20:42
import opentelemetry.trace as trace
from opentelemetry.context.context import Context
from opentelemetry.trace.propagation import textmap
from opentelemetry.propagate import textmap
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be propagators?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, thanks for catching

@lzchen lzchen closed this Mar 2, 2021
@lzchen lzchen reopened this Mar 2, 2021
@codeboten codeboten merged commit a046518 into open-telemetry:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relocate Getter and Setter to context/propagation

3 participants