Remove unnecessary warning when setting status description for non-error status#1721
Merged
lzchen merged 3 commits intoopen-telemetry:mainfrom Apr 2, 2021
Merged
Conversation
owais
requested review from
a team,
srikanthccv and
toumorokoshi
and removed request for
a team
Currently we log a warning that status description should only be set for an error condition even when description is not being set. This commit silences such warnings.
owais
force-pushed
the
fix-unnecessary-status-warning
branch
from
2a94455 to
dcc3c98
Compare
srikanthccv
approved these changes
Mar 28, 2021
lzchen
approved these changes
Mar 30, 2021
owais
changed the title
codeboten
approved these changes
Apr 1, 2021
toumorokoshi
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we log a warning that status description should only be set
for an error condition even when description is not being set. This
commit silences such warnings.
Type of change
Please delete options that are not relevant.
Checklist: