Merged
Conversation
codeboten
requested review from
a team,
aabmass and
lzchen
and removed request for
a team
Contributor
|
I think it's fine to have the metrics protos in our main branch. The stable/experimental branch separation we did was purely for implementation on the Python side of the metrics api/sdk. Also, since the proto is marked as stable it makes sense that we would keep this here. We probably would want to merge this into the metrics branch eventually as well. |
lzchen
approved these changes
May 26, 2021
codeboten
added
the
Approve Public API check
added 4 commits
May 26, 2021 14:16
srikanthccv
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerated the protos to update to 0.9.0. Note this also includes some metrics protos definitions, which I'm not sure if we should include or not. Would like some feedback on this. According to the maturity matrix, the metrics protos are now stable: https://github.com/open-telemetry/opentelemetry-proto#maturity-level
Fixes #1872
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: