Skip to content

use BoundedAttributes for attributes in link, event, resource, spans #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeboten merged 14 commits into from
Jun 25, 2021
Merged

use BoundedAttributes for attributes in link, event, resource, spans #1915

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e7550e7
use BoundedDict for attributes in link, event, resource, spans
Jun 16, 2021
f237bae
update changelog
Jun 16, 2021
a8e923a
Merge branch 'main' into codeboten/api-bounded-dict
Jun 16, 2021
c00d04a
fix mypy
Jun 21, 2021
09ca0a3
Merge branch 'main' into codeboten/api-bounded-dict
Jun 21, 2021
9bd9596
fix lint
Jun 21, 2021
736500d
removing unused vars
Jun 21, 2021
c9662ed
removing _create_immutable_attributes
Jun 21, 2021
943b078
add lock to delete
Jun 21, 2021
f05094d
add value error message
Jun 21, 2021
f29c775
fix __repr__
Jun 21, 2021
48a378d
Merge branch 'main' into codeboten/api-bounded-dict
Jun 24, 2021
8a84a0a
rename BoundedDict to BoundedAttributes
Jun 24, 2021
1b98aa9
fix lint
Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix __repr__
  • Loading branch information
Alex Boten committed Jun 21, 2021
commit f29c775c3e60f79d4d9659ee88ca5b30f40a2f66
9 changes: 7 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,13 @@ def __init__(
)

def __repr__(self):
return "max_attributes={}, max_events={}, max_links={}".format(
self.max_attributes, self.max_events, self.max_links
return "{}(max_attributes={}, max_events={}, max_links={}, max_event_attributes={}, max_link_attributes={})".format(
type(self).__name__,
self.max_attributes,
self.max_events,
self.max_links,
self.max_event_attributes,
self.max_link_attributes,
)

@classmethod
Expand Down