Add safeties for classes and functions#2152
Closed
ocelotl wants to merge 14 commits intoopen-telemetry:mainfrom
Closed
Add safeties for classes and functions#2152ocelotl wants to merge 14 commits intoopen-telemetry:mainfrom
ocelotl wants to merge 14 commits intoopen-telemetry:mainfrom
Conversation
ocelotl
added
Approve Public API check
Contributor
Author
|
@jsuereth this is the PR that would enable "empty" (or NoOp) instruments ✌️ |
Contributor
Author
|
This is being superseded by #2244, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a mechanism to make it possible to have classes and functions that don't raise errors but instead return NoOps.
Fixes #2148