Remove checks and callbacks from API#2164
Merged
ocelotl merged 2 commits intoopen-telemetry:metrics_newfrom Oct 12, 2021
Merged
Remove checks and callbacks from API#2164ocelotl merged 2 commits intoopen-telemetry:metrics_newfrom
ocelotl merged 2 commits intoopen-telemetry:metrics_newfrom
Conversation
Contributor
Contributor
Author
|
Removing checks until we have figured out a mechanism for error handling as defined in #2148 |
lzchen
reviewed
Oct 1, 2021
|
|
||
| _name_regex = compile_(r"[a-zA-Z][-.\w]{0,62}") | ||
|
|
||
| @property |
lzchen
approved these changes
Oct 1, 2021
aabmass
approved these changes
Oct 1, 2021
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
LGTM. Can we open up a follow up issue for the added todo/fixmes?
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Oct 13, 2021
* Remove checks and callbacks from API Fixes open-telemetry#2151 * Fix tests
aabmass
pushed a commit
to aabmass/opentelemetry-python
that referenced
this pull request
Oct 29, 2021
* Remove checks and callbacks from API Fixes open-telemetry#2151 * Fix tests
ocelotl
added a commit
that referenced
this pull request
Nov 2, 2021
* Remove checks and callbacks from API Fixes #2151 * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2151