Add MeterProvider and Meter to the SDK#2227

Merged

ocelotl merged 17 commits intoopen-telemetry:metrics_newfrom

ocelotl:issue_2200

Oct 28, 2021

Contributor

ocelotl commented Oct 19, 2021

Fixes #2200

ocelotl added the metrics label

ocelotl self-assigned this

ocelotl requested a review from a team

October 19, 2021 14:03

ocelotl marked this pull request as draft

October 19, 2021 14:03

ocelotl force-pushed the issue_2200 branch 6 times, most recently from 9d1ca32 to 94f4915 Compare

October 19, 2021 14:30

ocelotl marked this pull request as ready for review

October 19, 2021 14:44

ocelotl requested review from aabmass and lzchen

October 19, 2021 14:45

codeboten reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/api.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

lzchen approved these changes

View reviewed changes

aabmass reviewed

View reviewed changes

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Outdated Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py Show resolved Hide resolved

opentelemetry-sdk/src/opentelemetry/sdk/metrics/api.py Outdated Show resolved Hide resolved

opentelemetry-sdk/tests/metrics/test_metrics.py Show resolved Hide resolved

This was referenced Oct 26, 2021

Race condition in shutdown #2239

Closed

Add metrics prototype SDK #2059

Closed

ocelotl added 4 commits

October 27, 2021 16:35


          Add MeterProvider and Meter to the SDK

124aa1c

Fixes open-telemetry#2200


          Add FIXMEs

27c774a


          Fix docstring

9318f7b


          Add FIXME

c732284

ocelotl added 4 commits

October 27, 2021 16:35


          Fix meter return

df002c9


          Log an error if a force flush fails

48b3d3d


          Add FIXME

d4df303


          Fix lint

5ed35af

ocelotl force-pushed the issue_2200 branch from 99d24b5 to 5ed35af Compare

October 27, 2021 14:35

ocelotl added 7 commits

October 27, 2021 16:54


          Remove SDK API module

025c843


          Unregister

20a9e29


          Fix API names

1ff04f8


          Return _DefaultMeter

eca026f


          Remove properties

1ab1ba3


          Pass MeterProvider as a parameter to __init__

66af3f4


          Add FIXMEs

6248a4d

ocelotl mentioned this pull request

Add a Once wrapper as well to shutdown #2245

Closed


          Add FIXMEs

f5b0e8c

ocelotl mentioned this pull request

Protect registers against race conditions #2246

Open


          Fix lint

bcf5350

ocelotl mentioned this pull request

Adds Aggregation and instruments as part of Metrics SDK #2234

Merged

aabmass approved these changes

View reviewed changes

ocelotl merged commit 7539592 into open-telemetry:metrics_new

aabmass mentioned this pull request

Merge metrics prototype (metrics_new) into main #2254

Merged

aabmass pushed a commit to aabmass/opentelemetry-python that referenced this pull request


          Add MeterProvider and Meter to the SDK (open-telemetry#2227)

18ae1f5

* Add MeterProvider and Meter to the SDK

Fixes open-telemetry#2200

* Add FIXMEs

* Fix docstring

* Add FIXME

* Fix meter return

* Log an error if a force flush fails

* Add FIXME

* Fix lint

* Remove SDK API module

* Unregister

* Fix API names

* Return _DefaultMeter

* Remove properties

* Pass MeterProvider as a parameter to __init__

* Add FIXMEs

* Add FIXMEs

* Fix lint

ocelotl added a commit that referenced this pull request


          Add MeterProvider and Meter to the SDK (#2227)

0017a3a

* Add MeterProvider and Meter to the SDK

Fixes #2200

* Add FIXMEs

* Fix docstring

* Add FIXME

* Fix meter return

* Log an error if a force flush fails

* Add FIXME

* Fix lint

* Remove SDK API module

* Unregister

* Fix API names

* Return _DefaultMeter

* Remove properties

* Pass MeterProvider as a parameter to __init__

* Add FIXMEs

* Add FIXMEs

* Fix lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels