Refactor Meter and MeterProvider#2296
Merged
ocelotl merged 13 commits intoopen-telemetry:mainfrom Dec 8, 2021
Merged
Conversation
ocelotl
added
Skip Changelog
ocelotl
force-pushed
the
issue_2292
branch
4 times, most recently
from
1734432 to
0855c9f
Compare
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 28, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 28, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 29, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 29, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 30, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Dec 2, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Dec 3, 2021
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Dec 4, 2021
overmeulen
reviewed
Dec 7, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
lzchen
reviewed
Dec 8, 2021
aabmass
reviewed
Dec 8, 2021
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
LGTM, only blocking comments are the callbacks
lzchen
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2292
Both
MeterandMeterProviderneed some refactoring (in the arguments they accept, the methods they have, how they interact with instruments, etc.). Refactoring them to get them ready for the next metrics PRs.Removing my previous comment as this has been explained in today's meeting.