Merge Asynchronous and Synchronous sum aggregations#2379
Merge Asynchronous and Synchronous sum aggregations#2379ocelotl merged 13 commits intoopen-telemetry:mainfrom
Conversation
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
aabmass
left a comment
There was a problem hiding this comment.
I know in my original prototype and doc, we had collect() -> Optional[Point] so that "the aggregations may also return None if no measurements were seen in this interval–the metric reader won't see see the point in this case." I remember there being some specification discussion around whether or not this is correct, but can't dig anything up.
Given the confusion and fact that this would be an optimization, should put that off till later and just do the simple thing to start?
All right, removed any association between |
codeboten
left a comment
There was a problem hiding this comment.
Please address conflicts.
Done, @aabmass plese review ✌️ |
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
This is done in order to identify the situation when aggregate has not been called before collect is.
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Fixes #2353