add support for 0 global attribute limit and tests#2398
Merged
owais merged 3 commits intoopen-telemetry:mainfrom Jan 21, 2022
Merged
add support for 0 global attribute limit and tests#2398owais merged 3 commits intoopen-telemetry:mainfrom
owais merged 3 commits intoopen-telemetry:mainfrom
Conversation
owais
approved these changes
Jan 21, 2022
srikanthccv
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SpanLimits now properly supports a global attribute limit of 0. Previously it would treat 0 the same as
None, and cause a cascade of limits to default.Added tests to verify this behavior (
test_span_zero_global_limit,test_span_zero_global_nonzero_model,test_span_zero_global_unset_model).Fixes #2392
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
opentelemetry-api/oropentelemetry-sdk/test/utilhave changed: Noscripts/that were copied over to the Contrib repo have changedpyproject.tomlisort.cfg.flake8.github/CODEOWNERis added: NoREADME.mdCONTRIBUTING.mdChecklist: