Implement MetricReaderStorage#2456
Merged
ocelotl merged 22 commits intoopen-telemetry:mainfrom Feb 23, 2022
Merged
Conversation
aabmass
force-pushed
the
metric-reader-storage-2378
branch
from
ab97a63 to
0d4778e
Compare
aabmass
force-pushed
the
metric-reader-storage-2378
branch
from
0d4778e to
04c954c
Compare
1 task
codeboten
reviewed
Feb 10, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
Feb 10, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
Feb 10, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
Feb 10, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
Feb 10, 2022
ocelotl
reviewed
Feb 11, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
srikanthccv
approved these changes
Feb 13, 2022
codeboten
approved these changes
Feb 14, 2022
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
aabmass
removed
the
Approve Public API check
lzchen
approved these changes
Feb 17, 2022
Tests still need to be fixed.
codeboten
reviewed
Feb 19, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
codeboten
force-pushed
the
metric-reader-storage-2378
branch
from
3e1b338 to
8557e85
Compare
ocelotl
reviewed
Feb 22, 2022
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Member
Author
|
@ocelotl I undid the changes to SdkConfiguration in 17ec159. The SynchronousMeasurementConsumer handles the async callbacks and passes the measurements just to the individual MetricReaderStorage being collected. @codeboten changes look good, I think this can be merged whenever |
ocelotl
approved these changes
Feb 22, 2022
Contributor
|
@aabmass please fix lint ✌️ |
Contributor
|
@codeboten can the pending conversations be solved or do we need more changes/discussion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements
MetricReaderStorage. See issue for more details and links to design doc.Fixes #2378
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a new test cases mocking out dependencies including one concurrency test for race condition. This is now wired into the
MeterProvider, so existing integration test cases cover it.Does This PR Require a Contrib Repo Change?
Checklist: