fix except handling in get_aggregated_resources#2464
Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom Feb 22, 2022
munagekar:patch-1
Merged
fix except handling in get_aggregated_resources#2464lzchen merged 4 commits intoopen-telemetry:mainfrom munagekar:patch-1
lzchen merged 4 commits intoopen-telemetry:mainfrom
munagekar:patch-1
Conversation
|
|
Avoids UnboundLocalError: local variable 'detected_resource' referenced before assignment if raise_on_error is True
lzchen
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor Fix with exception handling in get_aggregated_resources
Description
Fixes
This happen only if raise_on_error is True with a resource detector.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Run with and without patch.
Type of change
Please delete options that are not relevant.
Checklist:
Does This PR Require a Contrib Repo Change?