Capture exception information in log attributes#2531
Merged
lzchen merged 16 commits intoopen-telemetry:mainfrom Mar 21, 2022
Merged
Capture exception information in log attributes#2531lzchen merged 16 commits intoopen-telemetry:mainfrom
lzchen merged 16 commits intoopen-telemetry:mainfrom
Conversation
lzchen
commented
Mar 15, 2022
srikanthccv
reviewed
Mar 16, 2022
ocelotl
reviewed
Mar 17, 2022
ocelotl
reviewed
Mar 17, 2022
ocelotl
reviewed
Mar 17, 2022
ocelotl
reviewed
Mar 17, 2022
ocelotl
reviewed
Mar 17, 2022
ocelotl
suggested changes
Mar 17, 2022
Contributor
ocelotl
left a comment
ocelotl
left a comment
There was a problem hiding this comment.
There may be a couple bugs hidden in the implementation.
aabmass
reviewed
Mar 18, 2022
ocelotl
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2529
From specs:
Capture as attributes - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#errors-and-exceptions
Semantic conventions - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/exceptions.md#attributes