Skip to content

Add default aggregation #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 6 commits into from
Mar 29, 2022
Merged

Add default aggregation #2543

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d18fa2e
Add default aggregation
ocelotl Mar 22, 2022
ea68a5d
Add changelog
ocelotl Mar 25, 2022
841159c
Raise exception
ocelotl Mar 25, 2022
087160c
Fix lint
ocelotl Mar 28, 2022
8e475ff
Small fixes
ocelotl Mar 28, 2022
648c76f
Add more fixes
ocelotl Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small fixes
  • Loading branch information
@ocelotl
ocelotl committed Mar 28, 2022
commit 8e475ffec4b48d4e8fa6d887a6b014b8cfdfa81f
18 changes: 11 additions & 7 deletions opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,16 @@ class DefaultAggregation(_AggregationFactory):
This aggregation will create an actual aggregation depending on the
instrument type, as specified next:

`Counter` → `SumAggregation`
`UpDownCounter` → `SumAggregation`
`ObservableCounter` → `SumAggregation`
`ObservableUpDownCounter` → `SumAggregation`
`Histogram` → `ExplicitBucketHistogramAggregation`
`ObservableGauge` → `LastValueAggregation`
========================= ====================================
Instrument Aggregation
========================= ====================================
`Counter` `SumAggregation`
`UpDownCounter` `SumAggregation`
`ObservableCounter` `SumAggregation`
`ObservableUpDownCounter` `SumAggregation`
`Histogram` `ExplicitBucketHistogramAggregation`
`ObservableGauge` `LastValueAggregation`
========================= ====================================
"""

def _create_aggregation(self, instrument: Instrument) -> _Aggregation:
Expand Down Expand Up @@ -125,7 +129,7 @@ def _create_aggregation(self, instrument: Instrument) -> _Aggregation:
if isinstance(instrument, ObservableGauge):
return _LastValueAggregation()

raise Exception("Invalid aggregation type found")
raise Exception("Invalid instrument type found")


class _SumAggregation(_Aggregation[Sum]):
Expand Down