Make sure trace flags are parsed properly when extracting traceparent and expand tests#2577
Merged
srikanthccv merged 3 commits intoopen-telemetry:mainfrom Apr 1, 2022
Merged
Conversation
30b6511 to
4c6a0a7
Compare
ocelotl
approved these changes
Mar 30, 2022
4c6a0a7 to
50502bd
Compare
lzchen
approved these changes
Mar 30, 2022
srikanthccv
reviewed
Mar 31, 2022
srikanthccv
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
Fixes # (issue)(no current issue)Type of change
How Has This Been Tested?
test_extract_non_decimal_trace_flagsinopentelemetry-api/tests/propagators/test_propagators.pyand passes with the change toopentelemetry-api/src/opentelemetry/trace/propagation/tracecontext.py.Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist:
[ ] Documentation has been updated