Add InstrumentationScope and deprecate InstrumentationLibraryInfo#2583
Add InstrumentationScope and deprecate InstrumentationLibraryInfo#2583srikanthccv merged 13 commits intoopen-telemetry:mainfrom
Conversation
exporter/opentelemetry-exporter-jaeger-proto-grpc/tests/test_jaeger_exporter_protobuf.py
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
|
@srikanthccv please add a changelog ✌️ |
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Overall the change looks good. Would be good to capture the results (maybe just a comment in this PR) from testing this against both the collector v0.47.0 and v0.48.0
opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/util/instrumentation.py
Outdated
Show resolved
Hide resolved
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
If this change doesnt go out in 1.11.0, the deprecation version will need updating. Please add a changelog entry to let users know of the deprecation
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Please resolve the conflict and check if my suggestions make sense ✌️
Co-authored-by: Alex Boten <alex@boten.ca>
…hon into issue-2516
|
Hi! Without the Library -> Scope rename, Honeycomb customers can't send us OTLP traces or metrics with the current OTel Python version (v1.11.0). Our OTel ingest is pinned to an earlier otlp-proto (0.11.0) to support customers who are sending us metrics from older OTel SDKs using behavior that was deprecated last year. We are unable to arrange for data ingest that supports both that deprecated metric format and this deprecated library/scope rename because the deprecated metric behavior was removed before this rename. What can we do to help get this rename merged and released? |
|
|
5 participants
Description
This spec PR open-telemetry/opentelemetry-specification#2276 introduced the concept of
InstrumentationScope. Naming in our components is varying. The deprecatedInstrumentationLibraryfrom spec isInstrumentationInfo. And the arguments naming have the mixed usage of "module" and "library"instrumenting_module_nameandinstrumenting_library_version. I introduced another class and properties wherever necessary for backward compatibility and replaced in the experimental packages. I would like to test these changes manually but opening it for reviews.Fixes #2516