Aggregate together data from identical instruments#2603
Merged
ocelotl merged 5 commits intoopen-telemetry:mainfrom Apr 22, 2022
Merged
Aggregate together data from identical instruments#2603ocelotl merged 5 commits intoopen-telemetry:mainfrom
ocelotl merged 5 commits intoopen-telemetry:mainfrom
Conversation
lzchen
reviewed
Apr 20, 2022
lzchen
reviewed
Apr 20, 2022
ocelotl
force-pushed
the
issue_2557
branch
2 times, most recently
from
b0934c3 to
6af9060
Compare
lzchen
approved these changes
Apr 21, 2022
codeboten
reviewed
Apr 21, 2022
codeboten
approved these changes
Apr 21, 2022
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
The name of the method is a bit confusing to me, as it registers the instrument if not registered... i wouldn't expect that as the caller. not blocking as it can always be changed later
Co-authored-by: Alex Boten <alex@boten.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2557