Inform the user of conflicting view configuration#2608
Merged
ocelotl merged 15 commits intoopen-telemetry:mainfrom May 6, 2022
Merged
Inform the user of conflicting view configuration#2608ocelotl merged 15 commits intoopen-telemetry:mainfrom
ocelotl merged 15 commits intoopen-telemetry:mainfrom
Conversation
ocelotl
commented
Apr 16, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Apr 18, 2022
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
Here is my take on the spec wording
Try to apply the View configuration. If applying the View results in conflicting metric identities the implementation SHOULD apply the View and emit a warning.
Conflicting identities would be as described in the link; all the identifying properties of the Metric are the same (everything but description). This is distinct from the next sentence
If it is not possible to apply the View without producing semantic errors (e.g. the View sets an asynchronous instrument to use the Explicit bucket histogram aggregation) the implementation SHOULD emit a warning and proceed as if the View did not exist.
in addition to instrument/aggregation mismatches, another other semantic error would be "the presence of multiple Metric identities for a given name with the same Resource and Scope attributes.".
It's not 100% clear to me why it's specified this way, but that's my take. Wdyt?
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_2556
branch
3 times, most recently
from
e3a8734 to
c7aa3b2
Compare
lzchen
reviewed
Apr 27, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Apr 27, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_2556
branch
2 times, most recently
from
f29b9ec to
50e2de3
Compare
ocelotl
force-pushed
the
issue_2556
branch
2 times, most recently
from
0e22309 to
6c36e35
Compare
lzchen
reviewed
May 5, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/_view_instrument_match.py
Show resolved
Hide resolved
lzchen
reviewed
May 5, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
May 5, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
May 6, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/_view_instrument_match.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/_view_instrument_match.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader_storage.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
May 6, 2022
lzchen
reviewed
May 6, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/_view_instrument_match.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
May 6, 2022
…ew_instrument_match.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>
…ew_instrument_match.py Co-authored-by: Leighton Chen <lechen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2556