Skip to content

Rename Measurement to Observation#2617

Merged
ocelotl merged 5 commits intoopen-telemetry:mainfrom
ocelotl:issue_2451
Apr 20, 2022
Merged

Rename Measurement to Observation#2617
ocelotl merged 5 commits intoopen-telemetry:mainfrom
ocelotl:issue_2451

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Apr 18, 2022

Fixes #2451

@ocelotl ocelotl self-assigned this Apr 18, 2022
@ocelotl ocelotl requested a review from a team April 18, 2022 21:11
Copy link
Copy Markdown
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix doc errors.

@ocelotl ocelotl requested a review from lzchen April 18, 2022 22:40
@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Apr 18, 2022

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Apr 18, 2022

Here too in contrib.

@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Apr 18, 2022

Here too in contrib.

Right, fixing.

@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Apr 18, 2022

Here too in contrib.

Right, fixing.

Opened here

ocelotl and others added 5 commits April 19, 2022 18:05
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
@ocelotl ocelotl merged commit 3323ce2 into open-telemetry:main Apr 20, 2022
@ocelotl ocelotl deleted the issue_2451 branch April 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming observable callback return type from Measurement -> Observation

3 participants