Make necessary SDK metrics symbols private#2625
Merged
ocelotl merged 1 commit intoopen-telemetry:mainfrom May 2, 2022
Merged
Conversation
ocelotl
force-pushed
the
issue_2389
branch
3 times, most recently
from
6a57aa3 to
3b0c499
Compare
ocelotl
commented
Apr 29, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/aggregation.py
Show resolved
Hide resolved
srikanthccv
approved these changes
Apr 29, 2022
lzchen
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2389
Refactored to mach our API, PTAL @aabmass, @lzchen, @srikanthccv.