Implement MetricReader temporality controls#2637
Merged
ocelotl merged 12 commits intoopen-telemetry:mainfrom Apr 27, 2022
Merged
Implement MetricReader temporality controls#2637ocelotl merged 12 commits intoopen-telemetry:mainfrom
ocelotl merged 12 commits intoopen-telemetry:mainfrom
Conversation
ocelotl
force-pushed
the
issue_2627
branch
2 times, most recently
from
93dafb0 to
0d06123
Compare
srikanthccv
reviewed
Apr 24, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_view_instrument_match.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Apr 25, 2022
codeboten
reviewed
Apr 25, 2022
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Overall this looks good, just a few questions
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py
Show resolved
Hide resolved
codeboten
reviewed
Apr 26, 2022
codeboten
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2627
Fixes #2636