Add callback options with timeout to observable callbacks#2664
Merged
ocelotl merged 3 commits intoopen-telemetry:mainfrom May 7, 2022
Merged
Add callback options with timeout to observable callbacks#2664ocelotl merged 3 commits intoopen-telemetry:mainfrom
ocelotl merged 3 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
I think this one could use a changelog entry |
ocelotl
approved these changes
May 6, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/instrument.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
May 6, 2022
Member
srikanthccv
left a comment
There was a problem hiding this comment.
Also needs contrib update?
lzchen
approved these changes
May 6, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
CallbackOptionsdataclass to be passed into observable callbacks. This is to pass along atimeout_millisparam which the callbacks should respect. Any additional things we add in the future can be added to the dataclass in backward compatible way. The reason to use a dataclass over function arguments is:Part of #2663
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Need to update tests still
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
Checklist: