Skip to content

Fix #2689 LoggingHandler to handle exc_info=False#2690

Merged
lzchen merged 2 commits intoopen-telemetry:mainfrom
gen-xu:fix/2689
May 16, 2022
Merged

Fix #2689 LoggingHandler to handle exc_info=False#2690
lzchen merged 2 commits intoopen-telemetry:mainfrom
gen-xu:fix/2689

Conversation

@gen-xu
Copy link
Copy Markdown
Contributor

@gen-xu gen-xu commented May 15, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2689

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • opentelemetry-sdk/tests/logs/test_handler.py::test_log_exc_info_false

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@gen-xu gen-xu requested a review from a team May 15, 2022 03:53
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented May 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gen-xu / name: Gen Xu (6b41a64)

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@lzchen lzchen merged commit f1ff2a0 into open-telemetry:main May 16, 2022
@gen-xu gen-xu deleted the fix/2689 branch December 19, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opentelemetry.sdk._logs.LoggingHandler panics when exc_info is set to False for logger.error

3 participants