Skip to content

feat:: Added --insecure of CLI argument#2696

Merged
srikanthccv merged 21 commits intoopen-telemetry:mainfrom
xs-fork:main
Jul 26, 2022
Merged

feat:: Added --insecure of CLI argument#2696
srikanthccv merged 21 commits intoopen-telemetry:mainfrom
xs-fork:main

Conversation

@tonycody
Copy link
Copy Markdown
Contributor

@tonycody tonycody commented May 17, 2022

Description

CLI added the parameter '--insecure' to support whether or not to communicate securely. The opentElemetry auto instrument cannot use the 'insecure' parameter

Fixes # (issue)

@tonycody tonycody requested a review from a team May 17, 2022 10:46
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented May 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tonycody / name: xs (8d7e24f)

@tonycody tonycody requested a review from srikanthccv May 18, 2022 00:51
@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jun 25, 2022

@tonycody we can get this merged if you can address the minor comment and fix the failures.

@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jul 12, 2022

@tonycody ping.

@tonycody
Copy link
Copy Markdown
Contributor Author

tonycody commented Jul 14, 2022

@srikanthccv ping.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jul 14, 2022
@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jul 14, 2022

@tonycody Add changelog and fix lint. Also some new commits are added with XS user, please make sure to sign CLA with it.

@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jul 15, 2022

@tonycody your last four commits didn't have user id and preventing from easycla check to pass #2696 (comment).

tonycody added 2 commits July 19, 2022 15:11
@tonycody
Revert "append CHANGELOG.md"
fbdb845 
This reverts commit cce7649.
@tonycody
Revert "code format"
d61b3d7 
This reverts commit d8ecdb5.
@tonycody
Copy link
Copy Markdown
Contributor Author

tonycody commented Jul 19, 2022

@srikanthccv ping

@tonycody tonycody requested review from lzchen and srikanthccv July 19, 2022 07:20
@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jul 19, 2022

/easycla

@tonycody
Copy link
Copy Markdown
Contributor Author

tonycody commented Jul 19, 2022

@lzchen @srikanthccv review

@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jul 24, 2022

@tonycody fix the lint.

@ocelotl
Copy link
Copy Markdown
Contributor

ocelotl commented Jul 25, 2022

@tonycody just in case, here is an easy way to fix the lint errors:

Run .tox/lint/bin/black .
Run .tox/lint/bin/isort .

@tonycody
Copy link
Copy Markdown
Contributor Author

tonycody commented Jul 26, 2022

@srikanthccv @lzchen ping.

@srikanthccv srikanthccv merged commit c9222bf into open-telemetry:main Jul 26, 2022
@srikanthccv srikanthccv mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

+1 more reviewer

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tonycody @srikanthccv @ocelotl @lzchen