Skip to content
Prev Previous commit
Next Next commit
Add tests
  • Loading branch information
srikanthccv committed Jun 2, 2022
commit ff3d6b503d81c1948b8c745d7f56bb21360d0930
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,11 @@ def _import_config_components(

def _import_exporters(
trace_exporter_names: Sequence[str],
metric_exporter_names: Sequence[str],
log_exporter_names: Sequence[str],
) -> Tuple[Dict[str, Type[SpanExporter]], Dict[str, Type[LogExporter]]]:
trace_exporters = {}
metric_exporters = {}
log_exporters = {}

for (exporter_name, exporter_impl,) in _import_config_components(
Expand All @@ -188,6 +190,14 @@ def _import_exporters(
else:
raise RuntimeError(f"{exporter_name} is not a trace exporter")

for (exporter_name, exporter_impl,) in _import_config_components(
metric_exporter_names, "opentelemetry_metrics_exporter"
):
if issubclass(exporter_impl, MetricExporter):
metric_exporters[exporter_name] = exporter_impl
else:
raise RuntimeError(f"{exporter_name} is not a metric exporter")

for (exporter_name, exporter_impl,) in _import_config_components(
log_exporter_names, "opentelemetry_logs_exporter"
):
Expand All @@ -196,7 +206,7 @@ def _import_exporters(
else:
raise RuntimeError(f"{exporter_name} is not a log exporter")

return trace_exporters, log_exporters
return trace_exporters, metric_exporters, log_exporters


def _import_id_generator(id_generator_name: str) -> IdGenerator:
Expand Down
116 changes: 112 additions & 4 deletions opentelemetry-sdk/tests/test_configurator.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import logging
from os import environ
from typing import Dict, Iterable, Optional
from unittest import TestCase
from unittest.mock import patch

Expand All @@ -28,11 +29,19 @@
_import_exporters,
_import_id_generator,
_init_logging,
_init_metrics,
_init_tracing,
)
from opentelemetry.sdk._logs import LoggingHandler
from opentelemetry.sdk._logs.export import ConsoleLogExporter
from opentelemetry.sdk.metrics.export import ConsoleMetricExporter
from opentelemetry.sdk.metrics import MeterProvider
from opentelemetry.sdk.metrics.export import (
AggregationTemporality,
ConsoleMetricExporter,
Metric,
MetricExporter,
MetricReader,
)
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
from opentelemetry.sdk.trace.export import ConsoleSpanExporter
from opentelemetry.sdk.trace.id_generator import IdGenerator, RandomIdGenerator
Expand Down Expand Up @@ -60,6 +69,10 @@ def get_log_emitter(self, name):
return DummyLogEmitter(name, self.resource, self.processor)


class DummyMeterProvider(MeterProvider):
pass


class DummyLogEmitter:
def __init__(self, name, resource, processor):
self.name = name
Expand Down Expand Up @@ -92,6 +105,46 @@ def __init__(self, exporter):
self.exporter = exporter


class DummyMetricReader(MetricReader):
def __init__(
self,
exporter: MetricExporter,
preferred_temporality: Dict[type, AggregationTemporality] = None,
preferred_aggregation: Dict[
type, "opentelemetry.sdk.metrics.view.Aggregation"
] = None,
export_interval_millis: Optional[float] = None,
export_timeout_millis: Optional[float] = None,
) -> None:
super().__init__(
preferred_temporality=preferred_temporality,
preferred_aggregation=preferred_aggregation,
)
self.exporter = exporter

def _receive_metrics(
self,
metrics: Iterable[Metric],
timeout_millis: float = 10_000,
**kwargs,
) -> None:
self.exporter.export(None)

def shutdown(self, timeout_millis: float = 30_000, **kwargs) -> None:
return True


class DummyOTLPMetricExporter:
def __init__(self, *args, **kwargs):
self.export_called = False

def export(self, batch):
self.export_called = True

def shutdown(self):
pass


class Exporter:
def __init__(self):
tracer_provider = trace.get_tracer_provider()
Expand Down Expand Up @@ -278,6 +331,61 @@ def test_logging_init_exporter(self):
self.assertTrue(provider.processor.exporter.export_called)


class TestMetricsInit(TestCase):
def setUp(self):
self.metric_reader_patch = patch(
"opentelemetry.sdk._configuration.PeriodicExportingMetricReader",
DummyMetricReader,
)
self.provider_patch = patch(
"opentelemetry.sdk._configuration.MeterProvider",
DummyMeterProvider,
)
self.set_provider_patch = patch(
"opentelemetry.sdk._configuration.set_meter_provider"
)

self.metric_reader_mock = self.metric_reader_patch.start()
self.provider_mock = self.provider_patch.start()
self.set_provider_mock = self.set_provider_patch.start()

def tearDown(self):
self.metric_reader_patch.stop()
self.set_provider_patch.stop()
self.provider_patch.stop()

def test_metrics_init_empty(self):
_init_metrics({}, "auto-version")
self.assertEqual(self.set_provider_mock.call_count, 1)
provider = self.set_provider_mock.call_args[0][0]
self.assertIsInstance(provider, DummyMeterProvider)
self.assertIsInstance(provider._sdk_config.resource, Resource)
self.assertEqual(
provider._sdk_config.resource.attributes.get(
"telemetry.auto.version"
),
"auto-version",
)

@patch.dict(
environ,
{"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service"},
)
def test_metrics_init_exporter(self):
_init_metrics({"otlp": DummyOTLPMetricExporter})
self.assertEqual(self.set_provider_mock.call_count, 1)
provider = self.set_provider_mock.call_args[0][0]
self.assertIsInstance(provider, DummyMeterProvider)
self.assertIsInstance(provider._sdk_config.resource, Resource)
self.assertEqual(
provider._sdk_config.resource.attributes.get("service.name"),
"otlp-service",
)
reader = provider._sdk_config.metric_readers[0]
self.assertIsInstance(reader, DummyMetricReader)
self.assertIsInstance(reader.exporter, DummyOTLPMetricExporter)


class TestExporterNames(TestCase):
def test_otlp_exporter_overwrite(self):
for exporter in [_EXPORTER_OTLP, _EXPORTER_OTLP_PROTO_GRPC]:
Expand All @@ -302,8 +410,8 @@ def test_empty_exporters(self):

class TestImportExporters(TestCase):
def test_console_exporters(self):
trace_exporters, logs_exporters = _import_exporters(
["console"], ["console"]
trace_exporters, metric_exporterts, logs_exporters = _import_exporters(
["console"], ["console"], ["console"]
)
self.assertEqual(
trace_exporters["console"].__class__, ConsoleSpanExporter.__class__
Expand All @@ -312,6 +420,6 @@ def test_console_exporters(self):
logs_exporters["console"].__class__, ConsoleLogExporter.__class__
)
self.assertEqual(
logs_exporters["console"].__class__,
metric_exporterts["console"].__class__,
ConsoleMetricExporter.__class__,
)