Fix example tests on Win32.#302
Merged
c24t merged 1 commit intoopen-telemetry:masterfrom Nov 27, 2019
Merged
Conversation
They were previously failing with
OSError: [WinError 193] %1 is not a valid Win32 application
Since subprocess.Popen directly calls CreateProcess and the Windows
kernel doesn't support shebangs (even if it did, /usr/bin/env is not a
path that leads to a valid executable usually), we need to manually
specify sys.executable ('python' would not work since it would leave the
virtualenv).
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 33 33
Lines 1610 1610
Branches 180 180
=======================================
Hits 1379 1379
Misses 185 185
Partials 46 46Continue to review full report at Codecov.
|
codeboten
approved these changes
Nov 22, 2019
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Thanks for catching this!
c24t
approved these changes
Nov 27, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
closes open-telemetry#274 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were previously failing with
Since subprocess.Popen directly calls CreateProcess and the Windows
kernel doesn't support shebangs (even if it did, /usr/bin/env is not a
path that leads to a valid executable usually), we need to manually
specify sys.executable ('python' would not work since it would leave the
virtualenv).