Skip to content

Fix example tests on Win32.#302

Merged
c24t merged 1 commit intoopen-telemetry:masterfrom
dynatrace-oss-contrib:fix-example-win32
Nov 27, 2019
Merged

Fix example tests on Win32.#302
c24t merged 1 commit intoopen-telemetry:masterfrom
dynatrace-oss-contrib:fix-example-win32

Conversation

@Oberon00
Copy link
Copy Markdown
Member

They were previously failing with

OSError: [WinError 193] %1 is not a valid Win32 application

Since subprocess.Popen directly calls CreateProcess and the Windows
kernel doesn't support shebangs (even if it did, /usr/bin/env is not a
path that leads to a valid executable usually), we need to manually
specify sys.executable ('python' would not work since it would leave the
virtualenv).

They were previously failing with

    OSError: [WinError 193] %1 is not a valid Win32 application

Since subprocess.Popen directly calls CreateProcess and the Windows
kernel doesn't support shebangs (even if it did, /usr/bin/env is not a
path that leads to a valid executable usually), we need to manually
specify sys.executable ('python' would not work since it would leave the
virtualenv).
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 22, 2019

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files          33       33           
  Lines        1610     1610           
  Branches      180      180           
=======================================
  Hits         1379     1379           
  Misses        185      185           
  Partials       46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077a08e...a87fde5. Read the comment docs.

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@c24t c24t merged commit 5f311e0 into open-telemetry:master Nov 27, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
closes open-telemetry#274

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants