Regenerate opentelemetry-proto to be compatible with protobuf 3 and 4#3070
Merged
srikanthccv merged 5 commits intoopen-telemetry:mainfrom Dec 3, 2022
Merged
Conversation
aabmass
changed the title
aabmass
changed the title
aabmass
force-pushed
the
protoc-for-protobuf3-and-4
branch
from
309a4c3 to
8ac8e5c
Compare
aabmass
force-pushed
the
protoc-for-protobuf3-and-4
branch
from
8ac8e5c to
d4869e0
Compare
aabmass
added
the
Approve Public API check
srikanthccv
approved these changes
Dec 2, 2022
Member
Author
|
I tested it out and it actually failed for protobuf 3.19.. Leaving it as is and I updated the tox file to test specifically against protobuf 3.19.x. I think this is ready to go |
7 tasks
lzchen
approved these changes
Dec 3, 2022
gen-xu
approved these changes
Dec 3, 2022
Contributor
gen-xu
left a comment
gen-xu
left a comment
There was a problem hiding this comment.
LGTM! I have also done some benchmark locally myself with this PR and confirmed that the upb is properly loaded and brings performance improvements for protobuf serialization.
Member
|
Thanks, @aabmass! |
This was referenced Dec 3, 2022
|
A new release that includes these changes would be appreciated. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2880
Fixes #3050
I pinned
grpcio-tools==1.48.1dev dependency which provides protoc 3.19.4. This version appears to generate code compatible with both protobuf 3.x and 4.x. Then I regenerated the protobufs, and added tox envs to test the relevant packages against both versions of protobuf.Finally I widened the protobuf version specifier in the
opentelemetry-protopackage.