Skip to content

Fix handling of empty metric collection cycles #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 14 commits into from
Sep 7, 2023
Merged

Fix handling of empty metric collection cycles #3335

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3d684b5
Remove console exporter metric output if empty
ocelotl Jun 5, 2023
c55f8fa
Revert "Remove console exporter metric output if empty"
ocelotl Aug 15, 2023
8c2a43a
Speed up test execution
ocelotl Aug 16, 2023
a54b100
Do not produce any metric output without metric data
ocelotl Aug 16, 2023
1aeaf0c
Revert "Speed up test execution"
ocelotl Aug 17, 2023
032e98f
Fix lint
ocelotl Aug 17, 2023
c731316
Add another test for histograms
ocelotl Aug 21, 2023
7ffc2b5
Remove added spacing
ocelotl Aug 24, 2023
721d012
Update typing
ocelotl Aug 24, 2023
d9a078c
Fix typing for collect
ocelotl Aug 24, 2023
401cba9
Fix histogram test
ocelotl Aug 24, 2023
0aafae5
Make return more concise
ocelotl Sep 7, 2023
cb97ad3
Move return inside the lock
ocelotl Sep 7, 2023
58d1216
Add explanatory comment
ocelotl Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@ocelotl
ocelotl committed Sep 7, 2023
commit 032e98fccddade7b64ebdb5442274c8bc17b338d
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from logging import getLogger
from threading import Lock
from time import time_ns
from typing import Dict, List, Sequence, Optional
from typing import Dict, List, Optional, Sequence

from opentelemetry.metrics import Instrument
from opentelemetry.sdk.metrics._internal.aggregation import (
Expand Down