Skip to content

Add unit to view instrument selection criteria #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 6 commits into from
Jun 26, 2023
Merged

Add unit to view instrument selection criteria #3341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d3c268
Add unit to view instrument selection criteria
Jun 11, 2023
5dc8f4b
Add an entry for changelog
Jun 11, 2023
fe3c784
Fix after CR
Jun 11, 2023
a8d7f40
Merge branch 'main' into add-unit-to-view-instrument
shalevr Jun 14, 2023
aaee191
Merge branch 'main' into add-unit-to-view-instrument
srikanthccv Jun 16, 2023
46fdf58
Merge branch 'main' into add-unit-to-view-instrument
shalevr Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add an entry for changelog
  • Loading branch information
sroda committed Jun 11, 2023
commit 5dc8f4bd6fb3f59ee45fc4dcab4b1bd404154c7a
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased
- Use BoundedAttributes instead of raw dict to extract attributes from LogRecord and Support dropped_attributes_count in LogRecord ([#3310](https://github.com/open-telemetry/opentelemetry-python/pull/3310))
- Add unit to view instrument selection criteria
([#3341](https://github.com/open-telemetry/opentelemetry-python/pull/3341))

## Version 1.18.0/0.39b0 (2023-05-04)

- Select histogram aggregation with an environment variable
Expand Down
3 changes: 3 additions & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ class View:
card characters should not be used with this attribute if the view has also a
``name`` defined.

instrument_unit: This is an instrument matching attribute: the unit the
instrument must have to match the view.

meter_name: This is an instrument matching attribute: the name the
instrument meter must have to match the view.

Expand Down