Synchronous gauge prototype#3462
Merged
ocelotl merged 9 commits intoopen-telemetry:mainfrom Feb 5, 2024
Merged
Conversation
ocelotl
approved these changes
Dec 14, 2023
Contributor
|
Well done! ✌️ |
ocelotl
suggested changes
Dec 14, 2023
|
What's the status on this? I would very much like to get my hands on the synchronous gauge API. |
|
@sarafonseca-123 Why did you make |
Oh, because it's experimental? I only just now saw that in the resolved comments. |
185cc0d to
87e5a4c
Compare
ocelotl
approved these changes
Feb 3, 2024
auto-merge was automatically disabled
February 3, 2024 18:31
Pull Request is not mergeable
8426501 to
0549d48
Compare
auto-merge was automatically disabled
February 3, 2024 19:30
Pull Request is not mergeable
auto-merge was automatically disabled
February 3, 2024 19:30
Pull Request is not mergeable
|
The only thing missing here seems to be one leftover reference in the docs to |
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
85c9e37 to
50193fb
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a synchronous gauge instrument, based on opentelemetry-java PR Add experimental synchronous gauge #5506. It aims to give support to synchronous gauge as stated on opentelemetry-specification PR Add synchronous gauge instrument, clarify temporality selection influence on metric point persistence #3540.
Fixes # (issue)
#3363
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This change was tested with multiple unit tests, that were contributed.
Also, it was locally tested with a simple API in Flask integrating with an OTEL server deployed on Kubernetes, using Python 3.8.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: