Skip to content

Set Severity Text = WARN as defined#3566

Merged
ocelotl merged 4 commits intoopen-telemetry:mainfrom
pegasas:issues3548
Feb 10, 2024
Merged

Set Severity Text = WARN as defined#3566
ocelotl merged 4 commits intoopen-telemetry:mainfrom
pegasas:issues3548

Conversation

@pegasas
Copy link
Copy Markdown
Contributor

@pegasas pegasas commented Dec 3, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3548

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@pegasas pegasas requested a review from a team December 3, 2023 05:53
auto-merge was automatically disabled February 1, 2024 16:28

Pull Request is not mergeable

@ocelotl ocelotl enabled auto-merge (squash) February 9, 2024 18:18
auto-merge was automatically disabled February 9, 2024 18:24

Pull Request is not mergeable

@ocelotl ocelotl enabled auto-merge (squash) February 10, 2024 03:14
@ocelotl ocelotl merged commit d829e37 into open-telemetry:main Feb 10, 2024
Krishnachaitanyakc added a commit to Krishnachaitanyakc/opentelemetry-python that referenced this pull request Mar 25, 2026
The OTel specification defines the severity text for the highest severity
range as "FATAL", but the Python SDK was passing through Python's native
"CRITICAL" level name unchanged. This is the same class of bug that was
previously fixed for WARNING -> WARN in open-telemetry#3566.

Fixes open-telemetry#4984
Krishnachaitanyakc added a commit to Krishnachaitanyakc/opentelemetry-python that referenced this pull request Mar 25, 2026
The OTel specification defines the severity text for the highest severity
range as "FATAL", but the Python SDK was passing through Python's native
"CRITICAL" level name unchanged. This is the same class of bug that was
previously fixed for WARNING -> WARN in open-telemetry#3566.

Fixes open-telemetry#4984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logs: Severity Text string does not match the spec

3 participants