Skip to content

Add to_json method to ExponentialHistogram#3780

Merged
lzchen merged 6 commits intoopen-telemetry:mainfrom
rbtz-openai:rbtz/expHistToJson
Apr 2, 2024
Merged

Add to_json method to ExponentialHistogram#3780
lzchen merged 6 commits intoopen-telemetry:mainfrom
rbtz-openai:rbtz/expHistToJson

Conversation

@rbtz-openai
Copy link
Copy Markdown
Contributor

@rbtz-openai rbtz-openai commented Mar 13, 2024 •
edited
Loading

Description

This fixes console exporter for ExponentialHistogram.

Fixes #3579

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rbtz-openai rbtz-openai requested a review from a team March 13, 2024 20:48
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

xrmx
xrmx reviewed Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a test while you are at it

@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 14, 2024

It would be nice to add a test while you are at it

I did not find a good existing place for exporter tests. Would a console exporter's integration test suffice?

@rbtz-openai rbtz-openai requested a review from pmcollins March 14, 2024 22:58
@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 14, 2024

@xrmx is it changelog worthy, or should we just add "Skip Changelog"?

@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Mar 18, 2024

@xrmx is it changelog worthy, or should we just add "Skip Changelog"?

Since this is user visible I think it'll be good to have it recorded in the Changelog

@rbtz-openai rbtz-openai requested a review from xrmx March 19, 2024 02:56
@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 19, 2024

@xrmx can you please kick off the tests?

@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Mar 20, 2024

@xrmx can you please kick off the tests?

Sorry, I don't have enough powers

@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 20, 2024

@pmcollins when you have a second, can you please kick off the tests, and maybe merge if it looks good?

@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 21, 2024

@pmcollins can you please add the "Skip Public API check" label?

Currently the check thinks that:

The code in this branch removes the following public symbols:

- opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
	OTEL_SDK_DISABLED

even though i did not touch that code.

@rbtz-openai rbtz-openai force-pushed the rbtz/expHistToJson branch 2 times, most recently from 60c7f76 to 61ebe89 Compare March 22, 2024 19:17
@rbtz-openai rbtz-openai requested a review from pmcollins March 22, 2024 19:19
@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 29, 2024

@pmcollins a friendly ping =) (and maybe @srikanthccv)

@pmcollins
Copy link
Copy Markdown
Member

pmcollins commented Mar 29, 2024 •
edited
Loading

Thank you for your patience :). Can you fix lint @rbtz-openai ?

@rbtz-openai
Copy link
Copy Markdown
Contributor Author

rbtz-openai commented Mar 30, 2024

Updated, now it passes:

python scripts/eachdist.py lint --check-only

But, sadly, fails publicAPICheck

@pmcollins
Copy link
Copy Markdown
Member

pmcollins commented Apr 1, 2024

Nice. That failure appears to be unrelated -- we'll have to chase it down separately.

@lzchen lzchen merged commit 5ff9046 into open-telemetry:main Apr 2, 2024
ocelotl pushed a commit to SecuringCarter/opentelemetry-python that referenced this pull request Apr 2, 2024
@rbtz-openai @ocelotl
Add to_json method to ExponentialHistogram (open-telemetry#3780)
4306280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@pmcollins pmcollins pmcollins approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExponentialHistogram is missing the to_json method

4 participants

@rbtz-openai @xrmx @pmcollins @lzchen