Merged
Conversation
Contributor
|
|
Contributor
Author
|
There's a new error from the async context manager: which I don't know how to fix |
Contributor
Author
|
@QuentinN42 any hint on fixing the issue above? ↑ |
Contributor
|
I don't really remember how I typed the thing but it was a pain :( I will try to take a look at this before today's meeting and come with more data. |
QuentinN42
reviewed
Mar 25, 2024
QuentinN42
reviewed
Mar 26, 2024
Fixes the following mypy errors: Call to abstract method "<method>" of "<class>" with trivial body via super() is unsafe [safe-super]
Silences the following error: A function returning TypeVar should receive at least one argument containing the same TypeVar [type-var]
Incompatible return value type (got "Callable[[VarArg(Pargs), KwArg(Pkwargs)], _AgnosticContextManager[R]]", expected "Callable[P, _AgnosticContextManager[R]]") [return-value] Co-authored-by: QuentinN42 <32516498+QuentinN42@users.noreply.github.com>
aabmass
approved these changes
Mar 26, 2024
lzchen
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump mypy to 1.9.0. This should allow adding python 3.12 to CI.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: