Fix collection of exponential histogram#3798
Merged
ocelotl merged 11 commits intoopen-telemetry:mainfrom Apr 5, 2024
Merged
Conversation
euroelessar
commented
Mar 20, 2024
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/buckets.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
Contributor
|
cc: @ocelotl |
Contributor
|
Love the explanation near the code changes, thanks @euroelessar ! |
rbtz-openai
reviewed
Mar 22, 2024
...try-sdk/tests/metrics/exponential_histogram/test_exponential_bucket_histogram_aggregation.py
Show resolved
Hide resolved
srikanthccv
reviewed
Mar 25, 2024
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
Show resolved
Hide resolved
Contributor
Author
|
@srikanthccv thanks! can you recommend some other approver/maintainer to review this pr as well so it could be merged, please? |
Member
|
@ocelotl will do another review. He already assigned this to him. |
8 tasks
… into fix-exponential-histogram
… into fix-exponential-histogram
ocelotl
approved these changes
Apr 5, 2024
auto-merge was automatically disabled
April 5, 2024 00:55
Pull Request is not mergeable
auto-merge was automatically disabled
April 5, 2024 00:55
Pull Request is not mergeable
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix various small issues in exponential histogram collection discovered by a newly added test and issues mentioned below:
self._scaleto be consistent with current bucket's scalescaleof the correct buckets alongside the buckets to method callsmin,max,sum,count,zero_countvalues across collection callsindex_baseinstead ofindex_start, also take wrapping around the buffer into accountindex_startand new index instead ofindex_endindex_startmatchesindex_baseFixes #3393
Fixes #3600
Fixes #3562
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: